Submitted about 2 months ago

Qr Code

VIvan Chauhan•40

@vivanchauhan

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Community feedback

cndofx•50
@cndofxPosted about 2 months ago
A couple things I would change:

Don't center your container element with the transform property. Try something like making your body either a flex or a grid container and centering its children:

body { display: flex; justify-content: center; align-items: center; }

Remove the fixed height from your container and text classes so that the content can determine the proper height to avoid overflowing.

Don't use a percent unit for the border radius as this causes the corners to be uneven on non square elements. Instead, try a unit like px or rem.
Marked as helpful
0
VIvan Chauhan•40
@vivanchauhanPosted about 2 months ago
@cndofx learning new things everyday thankyou.
0
Steven Stroud•11,910
@StroudyPosted about 2 months ago
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…

Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

Dont need to wrap your image in a <div>,

<div class="container"> <img src="image-qr-code.png" alt="qrimage" /> <div class="text">

Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
0
VIvan Chauhan•40
@vivanchauhanPosted about 2 months ago
@Stroudy Thank you so much for your thoughtful comment! I really appreciate your feedback, and I'll definitely take your suggestions into account as I continue to improve my future projects.
1
Steven Stroud•11,910
@StroudyPosted about 2 months ago
Hey @vivanchauhan, Once again, No problem bro, If you found it helpful I would greatly appreciate it if you marked it as so, Im trying to get mentor of the month 🙏
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord