QR Code

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,080

  @MelvinAguilarPosted about 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestion about your code that might interest you.

  • To center an element vertically, you should use a height to its container and add align-items: center;. In this case it is recommended to use "min-height: 100vh" so that it occupies 100% of the viewport height. e.g.:

  .container {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted about 2 years ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • Avoid using absolute length units px because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here.

  I hope you find it useful! 😄 Above all, you did a good job!

  Happy <coding /> 😎!

  Marked as helpful

  0