Travolgi 🍕• 31,420
@denielden
Posted
Hello Nilesh, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove all
margin
from.container
class because with flex they are superfluous and addwidth: 20rem
- add
width: 100%
toimg
tag and removebackground and border
properties because not necessary - use flexbox property
align-items: center and flex-direction: column
to the body to center the card. Read here -> best flex guide - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0