@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change.containerinto a<main>. -
The alt text should be written naturally, without using
-between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io). -
.attributionshould be a<footer>, and its text must be wrapped in a<p>.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Always include a proper CSS Reset at the top.
-
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
Remove
marginon.card. -
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
Remove
max-widthon.container. -
Remove
marginon.container. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
On the image, add
display: blockand changewidthtomax-width: 100%- the max-width prevents it from overflowing its container.
@gauravgorane
Posted
@Islandstone89 Thanks, I'll make sure that this mistake won't happen again.
