Skip to content
Submitted 8 months ago

QR Code

gauravgorane•340
@gauravgorane
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Code format is something I learn while coding, and it could get better and better over time.

What challenges did you encounter, and how did you overcome them?

Certain properties I learn while styling an image help me achieve better results.

What specific areas of your project would you like help with?

I guess I should concentrate on the grid section since I am currently having trouble figuring it out.

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted 8 months ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .container into a <main>.

    • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

    • .attribution should be a <footer>, and its text must be wrapped in a <p>.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Always include a proper CSS Reset at the top.

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • Remove margin on .card.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • Remove max-width on .container.

    • Remove margin on .container.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

    1
    gauravgorane•340
    @gauravgoranePosted 8 months ago

    @Islandstone89 Thanks, I'll make sure that this mistake won't happen again.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord