QR Code

Community feedback

• 

  P

  Koda👹•3,830

  @kodan96Posted 5 months ago

  hi there! 👋

  A couple of tips:

  HTML:

  • all of your content within the body should be contained by landmarks. these landmarks are the header, main and footer HMTL elements. for a project like this use at least a <main> tag

  • all HTML documents need an h1 tag (one and only one) and you shouldn't jump levels. so h1 should be followed by h2, that can be followed by 1 or more h3 elements, and when you start your next section you can go back to h2. you can think of it like h1 is the title of the page, h2-s are the title of the sections, h3-s are subtitles for the h2 elemetns etc.

  • I don't think the avatar is a purely decorative img in this case, so you should give it a descriptive alt attribute

  CSS:

  • don't use pixels, use relative units for font-size and other properties, even for margins and paddings.

  • centering your content with margin is not the best idea, you can apply these to the body tag to achieve the centering:

  body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
  }
  

  if you have multiple elements you should also include flex-direction: column;

  Hope this was helpful 🙏

  Good luck and happy coding! 🙌

  Marked as helpful

  0

  ---

  

  M Bilal Arsal•80

  @Bilal2417Posted 5 months ago

  @kodan96 thank you for your guidance 🙏🏻 I will surely apply these important features in my further projects Guidance from people like you will surely help me in my career .

  1