qr code

Community feedback

• 

  RabbitMaid•1,020

  @AgbortokoPosted over 1 year ago

  • HTML5 elements such as <main>, <nav>, <header>, <footer>, <section>, <aside> act as landmarks, or special regions on the page to which screen readers and other assistive technologies can jump. By using landmark elements, you can dramatically improve the navigation experience on your site for users of assistive technology (Users with disabilities) .

  You can use the <div> for sub items within landmarks like <section>. In other words for containers or sections in your html you can use the <section> tag.

  It is advisable that you place all your main site content in a landmark element <main>

  Here is an Accessibility Evaluation Tool to check your webpage for any errors or warnings related to landmarks.

  I hope you find the above solution useful! 😄 Nevertheless, the solution you submitted is great! Happy coding!

  Marked as helpful

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • The <div> tag can be useful for styling and positioning, but it doesn't convey any semantic meaning. Instead, consider using more semantic elements like <p> to better describe the type of content. e.g.: <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag, <div class="imp"> with <h1> and <div class="scan"> with <p> . click here for more on web-accessibility and semantic html

  There is no need to style .obrazek.

  There is no need to give the body a width value. To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

  For a responsive content, replace the width in .container and the img with max-width. Give .container a padding value for all the sides and reduce its max-width value. max-width: 320px padding: 16px.

  Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Ben•110

  @KrikoooPosted over 1 year ago

  @Hassiai thanks

  0