QR Code

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="large"> with the main tag and <p class="thick"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .large on the page using flexbox or grid instead position: absolute,

  add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .large on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .large on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Replace the height in .large/div with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding:15px. Give the img a max-width of 100% and border-radius value, the rest are not needed.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  SayHelloToKamil•40

  @SayHelloToKamPosted almost 2 years ago

  HTML

  • wrap the <div class="large"> ... </div> with the <main> tag to indicate it as the main component of the project

  • the alt attribute is important in the <img> tag. Give it a humanly understandable text. For example; <img class="qr-code" src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  CSS

  • use relative units like em or rem for padding, margin, width, and height. rem is preferred for font size. avoid using px since it is an absolute unit.

  Marked as helpful

  0