QR Code

Community feedback

• 

  paddypeanut•100

  @paddypeanutPosted 2 months ago

  Looks good overall, but the html structure could be improved, this in turn will give you more control over the css to get closer to the design.

  For example, I would wrap the component in another containing div and set this to flex and make the height full screen (100vh) and the center the component by using "justify-content:center;" and "align-items: center;" as apposed to using any margin to achieve this.

  The width of the component needs the be smaller. The text looks good but needs to be centered. This will achieve the multi line look of the design when the width is correct.

  Marked as helpful

  0
• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  It is really disheartening, That you have not onboarded any of my previous feedback on the last solution but amazing job with this! You’re making fantastic progress. Here are some small tweaks again from the last solution I think you should really implement that will take your solution to the next level…

  • If you add this to your body you can center the container vertically,

   min-height: 100svh;
    display: flex;
    justify-content: center;
    flex-direction: column;
    align-items: center;
  

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.
  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  I hope you found this advice helpful! Keep up the great work, and don’t forget to dive deeper into the details. You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀

  0