QR code

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  1

  ---

  

  Mladen Lamešević•80

  @MladenLmPosted over 2 years ago

  @Samadeen hi!

  Thank you very much for this feedback. This is golden! I was struggling with centering my div and also pushing attribution down.

  After studying the solutions of others I saw almost everyone making the body into display: flex which made things possible to center.

  Again, thank you for your feedback - looking forward to seeing your comments on my future submissions :)

  0

  

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  @MladenLm You welcome Mladen. You should also reduce the with on your container and just pad out the content

  1
• 

  Sadman Chowdhury Fahim•220

  @FahimEchoPosted over 2 years ago

  wow. great work

  1