girldocode• 260
@girldocode
Posted
it looks really nice. just apply border-radius to the image.
Marked as helpful
1
Zeus Tenerife• 80
@zakura1x
Posted
Thanks @girldocode will update the code
1
Design comparison
Solution retrospective
I'm not sure if its fully correct or not
Community feedback
P
Øystein Håberg• 9,450
@Islandstone89
Posted
Hi, yes it looks good, but there are a few things you should improve.. :)
HTML:
-
Your markup should have a main element
-
The image needs descriptive alt text.
CSS:
-
It's best practice to link to the fonts in the HTML
<head>instead of importing it in the CSS. -
Height on the body should be min-height.
-
Remove all fixed widths and heights. You rarely want to set a fixed size.
-
Remove
position: relativeandoverflow: hiddenon the .container
Marked as helpful
0
Zeus Tenerife• 80
@zakura1x
Posted
HTML
- Should I remove the container div if im gonna use a main tag?
CSS
- Will update the code with these thanks but I think the overflow does the job for fixing the border-radius. When i remove it. It made the container look like a square
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord