QR Code

Community feedback

• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  Hi Marek Brzezinski, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  Avoid using px, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem

  As this is the main image of the page it cannot have an empty alt, images must have alt text unless it is a decorative image!

  <img class="qrCode" src="images/qr-code.svg" alt="" />

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Marek Brzezinski•40

  @marekbrzePosted about 2 years ago

  @AdrianoEscarabote thank you for your comment! It forced me to finally read more about rems and I get it now ;) All of my next project will be better thanks to you ;)

  and good catch with alt property!

  1
• 

  Amobi Jonathan Chukwudi•350

  @JonathanthedeveloperPosted about 2 years ago

  Hey Marek, I noticed that you used a lot of divs . so you can refactor your code to

  
          <div class="cardContent">
            <h1>Improve your front-end skills by building projects</h1>
              <p>
                Scan the QR code to visit Frontend Mentor and take your coding
                skills to the next level
              </p>
          </div>
  
  

  instead of

  
          <div class="cardContent">
            <h1>Improve your front-end skills by building projects</h1>
            <div class="cardContent">
              <p>
                Scan the QR code to visit Frontend Mentor and take your coding
                skills to the next level
              </p>
            </div>
          </div>
  

  You

  Marked as helpful

  1

  ---

  

  Marek Brzezinski•40

  @marekbrzePosted about 2 years ago

  @Errorman2003 thank you! You are perfectly right. I thought I have to add div to add padding to the text because otherwise it wasn't working. Probably it was some kind of bug or my mistake because I corrected it and now it works perfectly.

  Thank you for your time to comment my project!

  0