Basic | Vanilla QR Code Component

Community feedback

• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hi there! 👋

  Great job on completing the challenge

  There are some accessibility issues with the code

  HTML

  • wrap the <div class="container"> ... </div> with the <main> tag to indicate it as the main component of the project

  • the alt attribute is important in the <img> tag. Give it a humanly understandable text. For example; <img class="qr-code" src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  • Use headings in order (i.e h1 -> h2 -> h3). Since there is only one main heading use <h1> instead of <h3>

  CSS

  • use relative units like em or rem for padding, margin, width, and height. rem is preferred for font size. avoid using px since it is an absolute unit.

  I hope this was useful 😊

  KEEP ON CODING

  Marked as helpful

  1