Design comparison
Solution retrospective
I don't know if I did everything right, as I'm new, so feedback saying where I can improve would be great
Community feedback
- @MelvinAguilarPosted 12 months ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
Avoid using
<br>
tags for line breaks as they disrupt the flow of screen-reader text. Learn more π -
Use descriptive
alt
attributes for images. For example, use "QR code to frontendmentor.io" instead of "qr code". Learn more π -
Prefer relative units like
em
orrem
over pixels for font-size to ensure scalability with browser settings. Resource π -
Use
min-height: 100vh
instead ofheight
to prevent cutting off components on smaller screens. -
Apply the
font-family: 'Outfit', sans-serif;
globally to the body or a container element instead of individually on each text element. This enhances organization and reduces redundancy.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord