Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I don't know if I did everything right, as I'm new, so feedback saying where I can improve would be great

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • Avoid using <br> tags for line breaks as they disrupt the flow of screen-reader text. Learn more πŸ“˜

  • Use descriptive alt attributes for images. For example, use "QR code to frontendmentor.io" instead of "qr code". Learn more πŸ“˜

  • Prefer relative units like em or rem over pixels for font-size to ensure scalability with browser settings. Resource πŸ“˜

  • Use min-height: 100vh instead of height to prevent cutting off components on smaller screens.

  • Apply the font-family: 'Outfit', sans-serif; globally to the body or a container element instead of individually on each text element. This enhances organization and reduces redundancy.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord