Design comparison
SolutionDesign
Solution retrospective
If I didn't have the main div with absolute positioning instead is static or relative, how can I center it vertically?
Community feedback
- @0xabdulPosted over 1 year ago
Hey there well congrats on completing the QR code component 🤩
- A Some recommendation for improve your code 📝
- In Html 🏷️ :
- whenever using the img tag put the alt attribute
- in fact using the img tag I'd attitude is not put please avoid this
- Ensure all informative <img> elements have short, descriptive alternate text and all decorative <img> elements have empty alt attributes (e.g. alt="").
- There are three main ways to add alternate text to an image:
Using an alt attribute i.e.
<img alt="drawing of a cat" src="...">
Using an aria-label i.e.<img aria-label="drawing of a cat" src="...">
Using an aria-labelledby attribute i.e.<img arialabelledby="someID" src="...">
- The Main landmark
- th html page should be contained one main landmark so fix them
- to clear the Accessibility reports using semantic elements or non semantic elements
- for easy way to clear the all Accessibility reports using non - semantic elements Ex :
<div> , <span>
- let's try
- Ex :
<body> <div class="container" role="main"> //Html code here 🏷️ </div> </body>
- OR
- using semantic elements Ex :
<aside> <section> <main> <nav> <header> < footer>
- Ex :
<body> <header>company logo header name...</header> <main> the main content here</main> <footer>@Copy right Here</footer> </body> </html>
- I Hope you find the solution and it's useful for you 😀
- Happy Coding
FlimzYT
🤩
Marked as helpful1@FlimzYTPosted over 1 year ago@0xAbdul Thanks alot! But im confused on what you mean by landmark and semantic elements
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord