QR CODE

Community feedback

• 

  Boris•340

  @Blagoja95Posted over 2 years ago

  Congratulation for finishing your first challenge. Some notes to take:

  • To fix those report issues found on your project, try to semantic HTML, put all your elements inside <main> tag, use <h1> element insted of <p> like you used for your component. More info about Semantic HTML: https://www.freecodecamp.org/news/semantic-html5-elements/ -Try to make your components close as possible to the provided design.

  All in all nice job, good luck.

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi batsy3, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • not use style inside html but write the css code into the css stylesheet
  • remove margin and max-height from container class and ser padding: 1rem
  • set width:100% to img element
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  0

  ---

  

  D!3 4 UZ!•10

  @batsy3Posted over 2 years ago

  @denielden THABK YOU FOR THE HELP

  1