Skip to content
Submitted 10 months ago

QR Code

Shiva Teja Bandameedi•10
@ShivaTeja1805
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Mennatallah Hesham•1,490
    @Mennatallah-HishamPosted 10 months ago

    Hi Shiva,

    Congratulations on completing your first challenge👏

    You did great 👍

    Here are some suggestions to improve your code:

    Semantic HTML

    • wrap your content in <main>,this element represents the dominant content of the <body>
    • wrap your card in <article>
    <main>
<article>
</article>
</main>
<footer>
</footer>

    Headings

    • each page should have one h1 tag,h1 helps the web understand the content. also skipping h1 may confuse assistive technology users.
     <h1>Improving your front-end skills by building projects</h1>

    IMAGE

    • when the image is set as a background, it wont be accessible for assistive technology users so it is better to use <img src="" alt=""/>
    • images should have descriptive alt text, which is important for SEO and screen reader users,alt="QR code linking to Frontend Mentor challenges"

    here are some helpful articles:

    Hope you find this helpful, Happy Coding

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord