QR Code

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have another small suggestion about your code that might interest you.

  • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    CSS resets that are widely used:

    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0

  ---

  

  aadithya1551•140

  @aadithya1551Posted 11 months ago

  Thank you for suggestion. It will be helpful for me and make it useful. Happy coding!

  0
• 

  Bryan Li•3,530

  @Zy8712Posted 12 months ago

  Your site looks pretty good. Some things I think you should add/change are:

  • adding <main> tags around your page's main content for accessibility purposes
  • for the title of the card you should use <h1> instead of <span>. Also instead of line breaks you should use margin-left and margin-right to adjust how much space the text has before it shifts over to the next line
  • instead of using margin-top: 50px, you should try using flex box to center your card. It could look something like:

  body {
      min-height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  Hope you find this feedback useful 👍

  Marked as helpful

  0

  ---

  

  aadithya1551•140

  @aadithya1551Posted 11 months ago

  Thank you for your feedback and sharing your ideas with me.

  0