QR Code

Community feedback

• 

  Tobias•100

  @ToHXPosted almost 3 years ago

  Good job! Some things which I did notice:

  • You're missing an h1 in your HTML
  • Class naming, do you use a specific format like BEM?
  • font-size always in REM
  • Fallback for the font-family is missing -Instead of for example Flexbox and padding you did work with fixed width and height which makes it not responsible (not an issue in this project though)

  Marked as helpful

  1
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great work with this one. Regarding the solution you submitted, I think you should also take notes of the following…

  • Remove margin-top: 10%; in .qrcode rule set and adjust into margin: 8rem auto;, padding-top: 1rem; and border-radius: 10px;
  • Remove margin-top: auto;, margin-left: auto; and margin-right: auto; in .qrtext and img rule set, add margin: auto;

  Above all, The design looks good. Keep it up! Hope this is helpful!

  Marked as helpful

  0
• 

  P

  BerlinWebDev•40

  @BerlinWebDevPosted almost 3 years ago

  Thanks for you Feedback. I will use them in the next projects.

  0