Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="wrapper"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
The background-color of the body is the font-color you gave to p and the font-color of p is
hsl(220, 15%, 55%);
,the background-color of the body.To center .wrapper on the using only flexbox instead of flexbox and position: absolute, add min-height:100vh to the body.
Replace the height in .wrapper with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement.
For a responsive content, give the img a max-width of 100% and replace the width in .wrapper with
max-width
.Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord