Design comparison
SolutionDesign
Solution retrospective
Fixed issues with github pages. Any and all feedback is welcome =)
Thank you!
Community feedback
- Account deleted
hi @afesta12! super clean work, your solution looks identical!
I am going to give you a couple of suggestions to avoid accessibility issues:
- Page should contain a level-one heading, you should change the <h2> tag to <h1> tag in this line of code:
<h2>Improve your front-end skills by building projects</h2>
- All page content should be contained by landmarks, in your solution you have a div that could easily be a footer:
<div class="attribution"> <-- remove <footer class="attribution"> --> add
I hope this feedback has been useful to you! keep coding :)
1@afesta12Posted over 2 years ago@nachogonzalia thank you!
I was wondering what it meant by accessibility issues, so that helped a lot.
Thank you for the feedback =)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord