Skip to content
Submitted 9 months ago

QR Code

alexstrauch•60
@alexstrauch
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I struggled in the beginning with the flexbox layout.

Next time, I' ll start with writing the HTML from start to finish and then the CSS, tweaking the HTML when I need to.

What challenges did you encounter, and how did you overcome them?

see above

What specific areas of your project would you like help with?

I'll keep working on different challenges to improve my HTML and CSS skills.

If someone has some pointers on what I could do differently I'm always open for feedback.

Community feedback

  • LuBrito•60
    @LuizadebritoPosted 9 months ago

    Well, I struggled with the semantic of HTML equally, so I made some tests in my code. I did some changes in CSS and when it doesn't worket I'd some chenges in HTML.

    So, I just took a look in your code and realised you don't necessary need to use the element <main>, istead you could put a <div class="container"> and inside you put another <div class="card">, so them inside of this card you will put de image and another <div class="text"> that would contain the elements <h2> and <p>. This div.text need to stay inside the div card like the image to work properly.

    You could get some vertical padding between the <h2> and the <img> to git some space to look more beautiful.

    This all is a some suggestion that would allow you to put a border-radius in the image and can be semantically correct too. I would increase spread in the shadow you put in de box to seem more natural and make the color more transparent.

    If I'm wrong, please someone correct me, cause I'm a beginner too.

    Marked as helpful
    0
    alexstrauch•60
    @alexstrauchPosted 8 months ago

    @Luizadebrito thank you very much, totally overlooked the rounded corners in the image, fixed that.

    0
  • Poorni Gopikrishnan•70
    @poorani11Posted 9 months ago

    -border-radius on the image -different box-shadow -font-sizes could match the design

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord