Qr code - 1st challange on frontmentor.io

Community feedback

• 

  Reuben👾•560

  @RubylenshyPosted about 2 years ago

  Hi @1991facundo 👋, a very nice job you've done here. However, here are some suggestions on how your build-up should look exactly like the design:

  • I see that @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap'); is not placed in the first line of your stylesheet code. Move that code up to the first line if you may.
  • Change <div class="container"></div> to <main></main> tag as this will show that it is the main content of the webpage, do a similar thing to the <div class="attribution"></div>, change that to a <footer></footer> tag.

  I hope this helps 👍

  Keep Coding @1991facundo

  Marked as helpful

  0

  ---

  

  Facundo•40

  @1991facundoPosted about 2 years ago

  @Rubylenshy Thank you very much for your help and advice!

  0
• 

  Akram Adjab•380

  @akramAdjabPosted about 2 years ago

  Hello @1991facundo, Congrats on completing this challenge

  I've checked your solution and noticed some errors you made

  • Always use a very light shadow, don't use a dark shadow as it will make your user experience very bad.
  • Try to reduce the title's font-size this is also to create a great user experience

  Hope my feedback was helpful 🙌🏻

  Marked as helpful

  0

  ---

  

  Facundo•40

  @1991facundoPosted about 2 years ago

  @akramAdjab Thanks for the feedback, it was helpful!

  0

  

  Akram Adjab•380

  @akramAdjabPosted about 2 years ago

  @1991facundo my pleasure 😀

  0
• 

  Eseoghene•550

  @EseAlliPosted about 2 years ago

  Great job Facundo, you can change and make the text look like the guide by setting a font size the h1 tag.

  .container h1{
   font-size: 1.5rem;
  }
  

  Marked as helpful

  0

  ---

  

  Facundo•40

  @1991facundoPosted about 2 years ago

  @EseAlli Thanks for the advice, much appreciated!

  0