PhoenixDev22• 16,950
@PhoenixDev22
Posted
Hi Jordy Mejia Castellano,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- You should use
<main>landmark to wrap the card . HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentornot describes the image. The alternate should not be hyphenated, it should be human readable.
- Page should contain
<h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>to wrapImprove your front-end skills by building projects.
- Never use
<div>and<span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.
So you can use <p> instead of <span>.
- In order to center the card on the middle of the page , you can use the
flexboxproperties andmin-height: 100vhfor the<body>add a little padding to the body that way it stops the card from hitting the edges of the browser .
- Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
- Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
Overall, Excellent work! Hopefully this feedback helps.
0
