Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

T
Grace 29,630

@grace-snow

Posted

Have a look at the feedback I've left on others solutions to this like this one as a lot of the same issues apply to yours: https://www.frontendmentor.io/solutions/html5-css-and-flexbox-aXZTaM1HQ3.

Definitely move the styles out into their own file, try to get the colours to match and you don't need overflow hidden anywhere so remove all those strange commented out lines of code. Also never use em for font size, use rem!

1
mshah007 10

@mshah007

Posted

I would use an external css file instead of using the style tags within html

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord