Design comparison
Community feedback
- @ARiYaNSEp0-0Posted 4 months ago
Hello @Ahmedshawky-cmd 🙋♂️, good job on completing qr code card. these are few improvements that you could apply to your code :
- your card box-shadow doesn't match design box-shadow so you could change that
- font weight of paragraph on design is regular or 400 but you have bold because of using just bold weight of Outfit font you can add two of them 400 and 700 to use that weight too
good luck :0)
Marked as helpful0@Ahmedshawky-cmdPosted 4 months agoThank you for the useful advice. I realized I didn't notice the font weight and box shadow and found it more visual than the design, by the way my design is higher than the original, did I need to do a margin-top or is this fine? @ARiYaNSEp0-0
0@ARiYaNSEp0-0Posted 4 months ago@Ahmedshawky-cmd no there is no need for that my friend this is a bug I guess because other ** qr code components ** have this problem too
Marked as helpful0 - @FahithKRMPosted 4 months ago
Hi, You have done best effort and good practice on your design task but you should modified your design as the pharagraph size is 15px and check wether that font weight is ok or not
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord