QR Challenged Solved, First Challeng of FrontendMentor
Design comparison
Community feedback
- @valvrauuPosted about 1 year ago
Hello, I really liked it! but the element is not centered (even with flex, because of viewport height), my suggestion:
remove the top margin and use it in the body: "min-height: 100vh;" and "margin: 0;".
Marked as helpful1 - @CristianAguilar-devPosted about 1 year ago
Hola amigo está genial tu diseño, puedo dejarte una sugerencia, para que tú contenedor principal este centrado puedes usar una técnica en selector universal para eliminar los márgenes y rellenos que están por defecto y desde tu body. Estableciendo un alto y ancho del 100% y dándole estilo flexbox. Por ejemplo:
- { box-sizing: border-box; margin: 0; padding: 0; body { width: 100vw; height: 100vh; display: flex; justify-content: center; align-items: center; } Espero pueda serte de ayuda en tu crecimiento profesional en este maravilloso mundo del frontend. 😊🤝
Marked as helpful0@JuanpitxDeveloperPosted about 1 year ago@Criszafiro muchas gracias amigo, justo eso estaba maquinando gracias gracias
0@CristianAguilar-devPosted about 1 year ago@JuanpitxDeveloper Congusto amigo estamos para servir en esta hermosa comunidad 🤝
1 - @lwrncgmbnPosted about 1 year ago
Hello, I noticed that the container itself is not centered, you can put this in the body {}:
min-height: 100vh
And remove the
margin-top: 125px;
in the .container{}.Happy Tasking 😄
Marked as helpful0 - @JuanpitxDeveloperPosted about 1 year ago
Any suggestions on how I can improve are welcome!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord