Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR challenge solution using html, css and flex.

@vladius9512

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. Is it ok if I made a container for the images and text instead of letting it without a wrapper into the body or the container wasn't needed here?
  2. The two <p> elements should each be inside a div or just placing them inside a wrapper is enough?
  3. I went for the max width and number of pixels on the image. It would have been better to work with rem/% instead of pixels?

Thank you for your time!

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="container"> with the main tag and <p class="heavy-font"> with <h1> to make the page accessible. click here for more on web-accessibility and semantic html

<div class="attribution"> should be out of <div class="container"> and wrap in the footer tag.

Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

To center .container on the page using flexbox, replace the height in the body with min-height: 100vh. There is no need to give .container a margin value.

Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord