Design comparison
Community feedback
- @RanitManikPosted 5 months ago
First of all, congratulations on completing your first frontend challenge here on Frontend Mentor! Everything looks great. Here are some suggestions from me:
-
Font Loading Optimization: Avoid using
@import
in CSS for font loading. Instead, directly link the fonts in the HTML file to enhance website performance, as explained in this article.<!-- Link Fonts in HTML --> <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Big+Shoulders+Display:[email protected]&family=Lexend+Deca:[email protected]&display=swap">
-
Unit Choice for Styling: Opt for using
rem
instead ofpx
for properties likewidth
,height
,margin
,padding
, andfont-size
. This choice ensures better scalability and responsiveness, as detailed in this article./* Use rem for Better Scalability */ .container { width: 57.4375rem; /* Equivalent to 919px */ height: 31.3125rem; /* Equivalent to 501px */ }
I hope you find my feedback helpful. Please mark it as helpful if you do.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord