Qr Challenge

Community feedback

• 

  Ritwik Pai•50

  @CoiferousYogiPosted about 2 months ago

  Hello. I just came across your post. First of all, well done for completing a challenge. Every challenge helps to learn something or the other. If you don't mind, let me share some points which will help you to improve. Your basic design of the card is good. But some of the areas can be improved.

  1. The area around the QR Code image. In the design, you can see that it's an uniformly spread area. I achieved this using the padding property. You can do this too by applying a padding of, say, 1rem to the div element containing the QR code image.
  2. Secondly, the same for the text elements below. Add an appropriate padding so that the text does not appear crossing the boundaries of the image.
  3. Please change the colour of the text elements. It's easy to miss that. Please refer to the design template to get the colours and apply them accordingly.
  4. For your query about the sizes and proportions of the elements, it's really about practice. Most of the times, you will have to experiment a bit to get the correct proportions. The solutions do not have to be a carbon-copy of the design if exact proportions have not been provided. Suppose, for this particular example, the card div is approximately a rectangle with a ratio between 3:2 and 4:3. I did this by experimenting on the div. Hope this helps.

  Wish you the very best.

  Marked as helpful

  0