Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Challenge

2VOLTAIC3 60

@2VOLTAIC3

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

oaved 90

@oaved

Posted

I think you did a great job. The HTML is semantic and simple to read. I dont see any aria-labels or what they are called. Maybe include some of those on your divs do make the website a little more accessible.

Im not that great at BEM so don't quote me on this, but is the main__card--container correct? I don't feel like it is a modifier which the -- indicated. Your design looks good though and that is what matters in the end. Great job!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord