
Design comparison
SolutionDesign
Please log in to post a comment
Log in with GitHubCommunity feedback
- @oaved
I think you did a great job. The HTML is semantic and simple to read. I dont see any aria-labels or what they are called. Maybe include some of those on your divs do make the website a little more accessible.
Im not that great at BEM so don't quote me on this, but is the main__card--container correct? I don't feel like it is a modifier which the -- indicated. Your design looks good though and that is what matters in the end. Great job!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord