QR card with flexbox

Community feedback

• 

  Atif Iqbal•3,200

  @atif-devPosted about 1 year ago

  Hi, congrats🎉 on completing the challenge. Better take about following points:

  • When we open GitHub repository link, at right side you will find an About Section. There, also include brief description and live preview link of your project. It is better for someone to check your live project while interacting with code.
  • Include a README.md file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
  • There are responsiveness issues in QR-code container. For a better preview, centered and appropriate responsiveness, modify code as:

  body {
    background-color: var(--LightGray);
    font-family: 'Outfit', sans-serif;
    display: flex;
    min-height: 95vh;
    justify-content: center;
    align-items: center;
  }
  

  .flex-container {
    background-color: var(--MyWhite);
    border-radius: 6%;
    padding: .8em .1em;
    width: 275px;
  }
  

  .contenedor_texto {
    border-radius: 10px;
    margin: 1% 7%;
    text-align: center;
  }
  

  Remove following code:

  @media only screen and (max-width: 600px) {
    .flex-container {
      width: 80vw;
      margin: 20% auto;
      padding: 5% 1%;
    }
  }
  

  (When you will be enough comfortable with CSS then better learn about responsiveness and responsiveness units. You can learn responsiveness units from a free short course Conquering Responsive Layouts).

  --Got any questions, REPLY--

  Hope you will find this Feedback Helpful.

  Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

  0

  ---

  

  Roxana Valeria Solernou•20

  @RoxxVSPosted about 1 year ago

  @atif-dev Thank you very much for your advice. I implemented some changes based on them and the project was much better.

  0