Skip to content
Submitted 3 months ago

QR card (SCSS + BEM)

Steven Stroud•11,890
@Stroudy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Hello, I'm Steven and this is my solution for this challenge using SCSS and BEM! 😊

🛠️ Built with:

HTML 🧾 SASS 🎨 BEM Notation 🅱️

Thank you to the Front-End Mentor team that creates these challenges that help us learning journey to front-end.💟

If you have any suggestions on how I can improve this project, feel free to leave me a comment!

Feedback welcome, as i am aware that there is so much to learn 😊

What challenges did you encounter, and how did you overcome them?

This is the first time using SCSS, So setting it up and then using the features took me abit to get my head around not to difficult in my honest opinion. Learned a lot about BEM aswell and implemented that into this project and future project as the default naming convention

What specific areas of your project would you like help with?

👂Feedback is highly appreciated no matter how big or small, I would like to know how it could be better and why, anything other best practices. I look forward to hearing from you all 💖

Community feedback

  • Boris•2,870
    @mkborisPosted 3 months ago

    Hi Stroudy this looks great, you can make it better by adding this lines of code on the body so that the card is properly centered. Doing this, you wouldn't need to use margins on the card to center it, you can remove the margins once this is set on the body.

        display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;

    Also, remove the height from the card completely and change the width to max-width. Avoid fixed heights and widths as they can hinder layout adaptability and content flow. Instead, allow padding and content to determine element sizes. Use max-width and min-height only when essential.

    Marked as helpful
    3
    Steven Stroud•11,890
    @StroudyPosted 3 months ago

    @mkboris Hello, thank you for your feedback i have made the correct adjustments, I did run into a issue where margin top was causing the 100vh not to work as intended but i have done it. Apricate you.

    1
  • Denner Silva•40
    @Denner-94Posted 3 months ago

    Gostei da sua solução!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord