Skip to content
Submitted 3 months ago

QR-card-responsive-with-flexbox

Jaime•150
@Jaimealicante83
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I developed it quickly and I found it easier to develop as I do these kind of things in my workplace. Next time I would write cleaner and better organized css code.

What challenges did you encounter, and how did you overcome them?

I wasn't sure how to center the card so I created a container with display flex and use align-self and justify-self in the card.

What specific areas of your project would you like help with?

How to improve efficiency and write better code

Community feedback

  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 3 months ago

    @Jaimealicante83

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things you could improve ✍️

    • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

    • You could add a min-height: 100vh to your main element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

    • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

    • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

    • You can center your card by changing your main styling to this:

    main {
    display: flex;
    flex-direction: column;
    background-color: #D5E1EF;
    height: 100vh;
    justify-content: center;
    align-items: center;
}

    You can remove align-self: center; and justify-self: center; from your container.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord