P
Øystein Håberg• 9,450
@Islandstone89
Posted
Hi, good job! You have a <main>, which many people forget to include. Your HTML and CSS is thoughtful and well-structured. Nice use of custom properties!
Just a few small tips...
-
I would also set up the font sizes as variables.
-
I like to use
min-heightinstead of height on the body, I feel that's more flexible. -
I think, in general, you should rarely set fixed widths and heights on things.
-
To avoid the image getting too large, you can set the following "reset", which I always have at the top of my stylesheet (along the
box-sizing: border-box, etc):
img {
display: block;
max-width: 100%;
}
All in all, though, well done :)
Marked as helpful
1
