Qr card component using Css, Html and flexbox

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="hero-sec"> with the main tag to fix the accessibility issue.

  There is no need to give the body a width and padding value. To center .hero-sec on the page using flexbox, replace the height in the body with min-height: 100vh.

  There is no need for a height value in .hero-sec increase the width and padding value for it to be equivalent to the design. width:320px, padding: 15px. Give the img a max-width of 100% instead of a width and height values.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Geethma•240

  @sahangeethmaPosted almost 2 years ago

  @Hassiai thank you

  0

  

  Obialor Ijeoma•30

  @IgraziellaPosted almost 2 years ago

  @Hassiai This has been very helpful, thanks a lot.

  0