QR card component

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi @rick881,

  Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great. There are some issues I want to address:

  1. It is great that you used the correct semantics for the footer however you should also wrap the main content within the main tag e.g. <main class="container"></main>
  2. Your box-shadow for the card is quite strong so I would recommend you making it lighter e.g. box-shadow: 10px 10px 20px rgba(0 0 0 0.1)
  3. Instead of using the position property of absolute on the footer, you could use the flex-direction property on the body, which will vertically align the footer and the container.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  0

  ---

  

  rick881•230

  @rick881Posted about 2 years ago

  Hi @romila2003 Thank you for your feedback and review it was insightful

  1