QR Card Component

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @AnggaSan08!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  gfunk77•1,200

  @gfunk77Posted 10 months ago

  Hi! Nice job on your solution. The card looks great. I noticed a couple of things:

  • You have some flex-box properties on body and img but display: flex; is missing. In order for justify-content and align-items to work, you first need to add display: flex; So, in your code those properties are not really doing anything.
  • You shouldn't really use the <br/> for places where you really want margin. I'd suggest removing those and adding some margin to the elements.
  • If you move the footer outside of the container, that content won't be in the card

  Again, great work on your solution!!. I hope these little suggestions are helpful.

  0