QR Card Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  CSS 🎨:

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  • Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the width property with a percentage value.

  • Consider centering your element using either a grid or flexbox layout for more precise and responsive centering.

    For Flexbox:

    body {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
      /* Additional styles if needed */
    }
    

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1

  ---

  

  Knast•20

  @knastPosted 12 months ago

  @MelvinAguilar Thank you for really detailed response and tips! I will surely implement them when I find time. I wish you happy coding too!

  0
• 

  adrnmatos•150

  @adrnmatosPosted 12 months ago

  Hi. Try putting some right and left padding to the blue container. It should grow to fit both padding and image sizes.

  0

  ---

  

  paradox143yab•10

  @paradox143yabPosted 12 months ago

  okay i will tnx@adrnmatos

  0

  

  Knast•20

  @knastPosted 12 months ago

  @adrnmatos I've already used padding on this container.

  0