Skip to content
Submitted almost 3 years ago

QR Card Component

Nico Arifin•260
@N1Coder
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Rio Cantre•9,690
    @RioCantrePosted almost 3 years ago

    Hello there! Awesome work with this one. Viewing at your solution, I would suggest the following for you...

    • Wrap the whole content card-component card with specific tag like main for readability
    • Remove the commented/unused code to keep it clean

    Overall you did well and Keep up the good work!

    Marked as helpful
    1
    Nico Arifin•260
    @N1CoderPosted almost 3 years ago

    @RioCantre Thank you for your feedback :D

    1
  • Lucas 👾•104,340
    @correlucasPosted over 2 years ago

    👾Hello Nico, congratulations for your new solution!

    Your solution is really good done and everything is fine, my advice for your is about cleaning your code, note that you've used a lots of divs to build this component and in reality you don't need more that the <main> to hold all the content (img, h1 and p). This is the cleanest code for the html structure:

    <body>
<main>
<img>
<h1></h1>
<p></p>
</main>
</body>

    To clean the css you can remove all class and select everyt element with the direct selector (img, h1, p, main and etc)

    👋 I hope this helps you and happy coding!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord