QR Card Component

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, perhaps some of this may interest you:

  HTML 🧱, ACCESSIBILITY ⚖:

  • Every page should have an <h1> to improve user experience and because it is an important element when it comes to SEO.

  CSS 🎨:

  • The page content could be centered using Grid or Flexbox. For example as follows:

  body {
  min-height: 100vh;
  display: grid;
  place-content: center;
  }
  

  • Length units such as pixels may not be the best alternative because absolute units don’t scale. Relative units like rem or em are a better option for scalable layouts (the page will adjust to the user's browser settings) and maintenance (to make changes without having to adjust every pixel value).

  Please let me know if you want more info on any of these topics or disagree with something. I hope it’s useful 🙂

  Regards,

  1

  ---

  

  Richard Kpehor•100

  @Richardedem6Posted over 1 year ago

  @fernandolapaz that is awesome, I look forward to learning more.

  0

  

  Fatih•30

  @mFatihGorhanPosted over 1 year ago

  @fernandolapaz Thank you very much for your constructive criticism. The information you provided is very valuable to me. However, I couldn't fully grasp the concept of rem and em and how to use them effectively. I am still struggling to understand how to apply them in practice. Also, I appreciate your guidance on using the grid for centering content.

  0

  

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  @mFatihGorhan You are welcome.

  Regarding the length units, you could easily start converting to rem (1 rem equals the font size of the root element, 16px by default).

  Marked as helpful

  0
• 

  Anuoluwapo-dev•80

  @Anuoluwapo-devPosted over 1 year ago

  You have done a good work on this project , Keep on and continue improving your skills. but you have done good generally!!

  0

  ---

  

  Richard Kpehor•100

  @Richardedem6Posted over 1 year ago

  @Anuoluwapo-dev thank you. I really appreciate the comment.

  0