Skip to content
Submitted about 1 year ago

QR Card Component

Sebastian Black•40
@SebbyVonBlack
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm currently on week 2 of learning Web Development (2nd week actually learning)

This challenge was my introduction to Frontend Mentor and my first time working with a design file. It was a great starter project to get me into the work cycle of not only using a design file, but commiting to Github more regularly.

The project it self wasn't anything too difficult, but still required me to look up things I had forgotten, as well as some things I hadn't quite learned yet.

If anything, I'd like comments on if my code was cleanly written, or if there was more I could have done to clean it up.

Community feedback

  • Mennatallah Hesham•1,490
    @Mennatallah-HishamPosted about 1 year ago

    Hi Sebastian,

    ** Congratulations on completing your first challenge**

    I would say you did great job

    here are some suggestions to improve your code: HTML

    • add meta description to improve SEO
    • make it a practice to wrap your content in a <main>
     <main class="card flex">
        <article class="card-content flex">
            <div class="card-img">
                <img src="images/image-qr-code.png" alt="qr code">
            </div>

            <div class="card-text">
                <h1>Improve your front-end skills by building projects</h1>
                <p>
                    Scan the QR code to visit Frontend Mentor
                    and take your coding skills to the next level
                </p>

                
            </div>
        </div>
    </main>
    • your alt text is good, but you can make it better by explaining what the qr is for ex:
      Frontend mentor qr code to access challenges

    some helpful articles :

    hope you find it helpful, Happy Coding

    Marked as helpful
    0
    Sebastian Black•40
    @SebbyVonBlackPosted about 1 year ago

    @Mennatallah-Hisham Thank you for the suggestions! I will update the project with those ideas.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord