Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Purfume Project By flex-box

sefoo333 250

@sefoo333

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@frank-itachi

Posted

Hello there 👋. Congratulation for completing the challenge👍!

I have some suggestions about your code that might interest you.

HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap the <div class=”attribution”> section.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.
  • It is a good practice to keep your CSS code in a different file, e.g. a stylesheet file where you can have your CSS rules in there. Avoid as much as you can in-line styles <div class="card" style="width: 18rem;...">

I hope you find it useful! 😄 Above all, you did a good job!

Happy <coding /> 😎!

0

sefoo333 250

@sefoo333

Posted

@frank-itachi Hello, thank you for your wonderful suggestion, I benefited a lot from your suggestion, because I had never heard of it before (picture code) And thanks again for your suggestion

0

@frank-itachi

Posted

@sefoo333 I'm happy to help.

Happy <coding /> 😎!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord