Pure HTML+CSS

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi, Alexsander!

  • HTML
    • wrap your code in main tags or change div class="container" to main="container
    • I personally wouldn't exclude P E R F U M E text from HTML as it provides additional information to people who use screen readers, but that is definitely a cool example of using ::before pseudo-selector 👍
    • use h1 instead of h2
    • I don't know a lot about accessibility but use del or s for the old price, plus some read-only text to provide more information
    • use the `picture`` element for providing two images that will change if the viewport gets to a certain width. Read this article it has great examples for different use cases

  • CSS
    • it is not recommended to set font-size: 62.5%; read about it here
    • use min-height: 100vh on the body element to allow scrolling, if you try to resize the window you will see that
    • I wouldn't separate CSS in two different files only if you use media queries in the head element so there wouldn't be additional calls to the server

  Keep it up! Can wait for your next solutions!

  Marked as helpful

  1