@eby-coder
Posted
Hi👋. Congrats on completing this challenge. I'll like to point out a few things that I think may help.
Firstly, it is the best practice to make your code as effective as possible. Therefore, any div or style that is not needed should be removed rather than put in comments.
<div class="attribution">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by <a href="unzila.dorik.io">Unzila02</a>.
</div>
It will be best to remove any unnecessary classes so that your code would look clean.
In addition, while your desktop view is beautiful, the mobile view doesn't look nice. This is because you set the width of ur container in percentage.
.container{
margin: 10% auto;
width:22%;
background-color:hsl(0, 0%, 100%) ;
border-radius: 15px;
}
This width: 22%
sets the width of the container to 22% of the screen's width, hence, while it may look okay when viewed with a laptop, when you use a phone, it looks bad.
The best way to set your width is to use pixels, so that the width is fixed regardless of what the screen size may be.
I hope this helps.😁
@Unzila02
Posted
@eby-coder sorry I just forgot to style. I style it later
@Unzila02
Posted
@eby-coder sorry I just forgot to style. I style it later and I learn bootstrap to make my site responsive so in next challenge I use bootstrap. Thank for guideline