pure html and css

Community feedback

• 

  Adriano•41,280

  @AdrianoEscarabotePosted 3 days ago

  Hello mo7amed5hairy, how are you? I was really pleased with your project, but I’d like to offer some advice that might help:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is spot on.

  Hope it’s helpful to you. 👍

  Marked as helpful

  0
• 

  Minn•70

  @MinTrannPosted 3 days ago

  Is it accessible, and what improvements could be made?

  Marked as helpful

  0

  ---

  

  Mohamed Khairy•60

  @mo7amed5hairyPosted 2 days ago

  @MinTrann yeah it is accessible you can visit the github link and see it , many improvements can be made actually for example the picture tag as adriano said in the previous comment also i noticed that i made a mistake by letting the attribution div out side <main> which is not correct and so many improvements bro

  0