Pure HTML & CSS , Flex box

Community feedback

• 

  Ximo Romero•340

  @Ximoromero6Posted 9 months ago

  Hi Mazen,

  I just checked your challange and I can say you did a great job, however let me give you some little datails to improve it a bit:

  • You could use the property min-height: 100vh on the body element and use flexbox to center vertically your container.
  • Also you can use the property line-height: 22px (you can play with the measures) to give some space to your paragraph.
  • The width of the border on the container should be 1px to make it closer to the given design.
  • And last, you could give a margin bottom on the part of the name.

  That's all! Have a good day Mazen :)

  Marked as helpful

  0

  ---

  

  Mazen Ahmed•30

  @Mazen922Posted 9 months ago

  I will apply it in my code 😊@Ximoromero6

  Thanks for your time.

  1
• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @Mazen922👋

  Amazing work🎉

  Just one suggestion for you regarding css basics, you need to add min-height:100vh which is missing in your main landmark to center your div and give some padding on it to look more responsive in mobile view also.

  Hope, this suggestion will help you!

  Happy Coding❤️

  Marked as helpful

  0

  ---

  

  Mazen Ahmed•30

  @Mazen922Posted 9 months ago

  Amazing @Bishalsnghd07

  I will do it , Thanks 😊

  0