Design comparison
Solution retrospective
open to suggestions
Community feedback
- @PhoenixDev22Posted almost 3 years ago
Hello @Starisblack , I have some suggestions regarding the solution:
-
Anything with a hover style in the design means it's interactive . You need to add an interactive element around the image ,
Equilibrium #3429
andJules Wyvern
(in this challenge is an anchor tag<a>
) -
The images
alt ="time" alt="eth"
don't need filledalt
. They are decorative images, soalt
attribute should be left intentionally blank. You can optionally addaria-hidden
orrole presentation
to ensure the images are always ignored by screen readers ANDimage-equilibrium.jpg"
and avatar's one shouldn't be empty read up about how and when to write alt text -
Text should never be in
divs
orspans
alone. Use a meaningful element. -
The eye image doesn't really need to be in the html, you could do it with css.
-
You can simply use unordered list
<div class="icons">
and in each list item would have<img >
and<p>
. -
You should use
em
andrem
units .Bothem
andrem
are flexible, scalable units which are translated by the browser into pixel values, depending on the font size settings in your design .Usingpx
won't allow the user to control the font size based on their needs. -
No need to use
<hr class="line">
, you can setborder-top
to the<div class="profile">
. -
This one
<div class="attribution">
should be a<footer>
and it should be out of the<main>
. -
It's rarely ever a good practice to set height on the element(
height: 85vh
) Let the content dictate how tall something needs to be.
Hopefully this feedback helps.
Marked as helpful0 -
- @anoshaahmedPosted almost 3 years ago
Hey good job! have at least one
<h1>
in your code:)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord