@Dipesh-sapkota1
Posted
Hi @RogelioCamargo 👏 Congratulation for completing front-end mentor challenge.🎉 I would like you to suggest two things, as per my experience so far it is not necessary to add height and width to a div. Naturally, browser tend to make web responsive, everything will fall into its place own its own and make necessary changes when it is required. We make web unresponsive by adding extra properties. Another suggestion I would like to give is that, make a habit of writing clean code, this will make your project scalable and manageable. You did great with this project and happy coding!
Marked as helpful
@RogelioCamargo
Posted
@Dipesh-sapkota1 Hey, appreciate the feedback and will def do that moving forward. could you elaborate on the second point? what about my code needs to be cleaner? I agree, but it would be fantastic if you could point to something that really stood out. I would love to know, thanks again!
@Dipesh-sapkota1
Posted
@RogelioCamargo What I meant about clean code is that, write code as simple as possible avoiding unnecessary repetition and remove what is not needed.
Marked as helpful
@RogelioCamargo
Posted
@Dipesh-sapkota1 Awesome, I will look back and clean up the code. Thanks for the feedback!
