Design comparison
Solution retrospective
how should I have done it better? thou i used pure CSS with media queries.
Community feedback
- @dalnokiPosted over 2 years ago
Hey @ogheneCodes,
For this challenge, there is no need to use media queries - the card's size shouldn't change, it's 320px wide so it will look nice even on a smaller mobile device (that has a resolution of 375px). If you take a look at the design comparison part of the solution, you can see that the background color does not match, and also the padding, the font size is different than the design.
You need to make sure that your solution looks good on any resolution (even though sometimes only the mobile and/or the desktop design is provided). In this particular case, if you make the width of the card fixed, it should be fine. If you take a look at your card at 1136px for example, the text overflows the card - so in the future, it's always advised to test your design at all resolutions.
It's a great thing you organized your files into folders.
Good luck to you on your learning journey!
Marked as helpful1 - @ogheneCodesPosted over 2 years ago
Thank you so much on this feedback, it means alot to me.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord