Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Pure CSS and HTML

Jose Rios 155

@joseriosdev

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feel free to give any feedback :D

Community feedback

Eric Salvi 1,330

@ericsalvi

Posted

Looking good.

A few things I would try instead. I would remove the margins on main and instead add some flex properties to the body to position the content in the dead center.

align-items: center;
display: flex;
flex-direction: column;
height: 100vh;
justify-content: center;

Adding the above to the body will center things for you. Also, you don't need to add the width: 100% on the button if the display is set to block. The 100% is actually causing the button to spill outside of its container. Display set to block is 100% essentially. 

I would also take a look at the padding of the containers on mobile. Seems to be a bit too tight.

Lastly, the content width is being set to 50vw so it is like 50% of the screen. The container seems too skinny right before it switches to mobile. Not totally responsive even though technically it is.

Other than those few things, you are doing a great job! Keep at it.

1
Jose Rios 155

@joseriosdev

Posted

Thanks a lot for your quick response, Eric! I'm going to definitely take a close look at what you said for future challenges :) and do these fixes.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord